Merged
Conversation
Contributor
maffettone
commented
Jun 11, 2025
maffettone
commented
- Adds an explicit launch file in the custom description package to run the ur driver with. This uses the custom config broadly, but leverages the upstream UR components when specifics are needed.
- Updates image manifests to point at NSLS2 repo
- Some slight markdown maintenance.
Contributor
Author
|
Can you have a look |
sixym3
approved these changes
Jul 8, 2025
sixym3
left a comment
sixym3
left a comment
There was a problem hiding this comment.
LGTM
Will need to refactor the Dockerfiles so that we can load beamline specific packages later but this is fine
nnessig
added a commit
to nnessig/erobs
that referenced
this pull request
Jul 9, 2025
fix: container concerns (NSLS2#61)
nnessig
pushed a commit
to nnessig/erobs
that referenced
this pull request
Jul 23, 2025
* fix: xacro * fix: try to make value constant * add: custom launch file * add: launch to cmake list * fix: backward compatability * fix: kinematics_params_file * maint: update readme and repo source
nnessig
added a commit
to nnessig/erobs
that referenced
this pull request
Jul 23, 2025
fix: container concerns (NSLS2#61)
nnessig
pushed a commit
to nnessig/erobs
that referenced
this pull request
Jul 23, 2025
* fix: xacro * fix: try to make value constant * add: custom launch file * add: launch to cmake list * fix: backward compatability * fix: kinematics_params_file * maint: update readme and repo source
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.